fix: don't duplicate NODE_OPTIONS (#353)

shakacode · Aug 29, 2023 · 4a6dd46 · 4a6dd46
1 parent 8617937
commit 4a6dd46
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/shakapacker/dev_server_runner.rb b/lib/shakapacker/dev_server_runner.rb
@@ -84,7 +84,7 @@ def execute_cmd
         end
 
         if @argv.delete("--debug-shakapacker") || @argv.delete("--debug-webpacker")
-          env["NODE_OPTIONS"] = "#{ENV["NODE_OPTIONS"]} --inspect-brk --trace-warnings"
+          env["NODE_OPTIONS"] = "#{env["NODE_OPTIONS"]} --inspect-brk --trace-warnings"
         end
 
         cmd += ["--config", @webpack_config]

diff --git a/lib/shakapacker/webpack_runner.rb b/lib/shakapacker/webpack_runner.rb
@@ -37,15 +37,15 @@ def run
       end
 
       if @argv.delete("--debug-shakapacker") || @argv.delete("--debug-webpacker")
-        env["NODE_OPTIONS"] = "#{ENV["NODE_OPTIONS"]} --inspect-brk"
+        env["NODE_OPTIONS"] = "#{env["NODE_OPTIONS"]} --inspect-brk"
       end
 
       if @argv.delete "--trace-deprecation"
-        env["NODE_OPTIONS"] = "#{ENV["NODE_OPTIONS"]} --trace-deprecation"
+        env["NODE_OPTIONS"] = "#{env["NODE_OPTIONS"]} --trace-deprecation"
       end
 
       if @argv.delete "--no-deprecation"
-        env["NODE_OPTIONS"] = "#{ENV["NODE_OPTIONS"]} --no-deprecation"
+        env["NODE_OPTIONS"] = "#{env["NODE_OPTIONS"]} --no-deprecation"
       end
 
       # Webpack commands are not compatible with --config option.