Test HMR with Rescript #37
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex35mil
reviewed
Apr 28, 2022
| "rescript-classnames", | ||
| "rescript-debounce-react", | ||
| "rescript-logger", | ||
| "bs-webapi" |
There was a problem hiding this comment.
You probably need only "@rescript/react for such test.
| "suffix": ".bs.js", | ||
| "bsc-flags": [ | ||
| "-open Belt", | ||
| "-open Cx" |
There was a problem hiding this comment.
Not needed, unless you plan to use rescript-classnames.
| "-open Cx" | ||
| ], | ||
| "ppx-flags": [ | ||
| "rescript-logger/ppx" |
There was a problem hiding this comment.
Not needed, unless you plan to userescript-logger.
|
@Judahmeek @mrtnzlml Should we add this to the example app? |
@justin808 I think the example with TypeScript is an excellent choice for the general public, and there is no need to complicate it with ReScript. For this reason, I'd say no. |
|
Also, you have this which I think is a much better place for such an example: https://github.com/shakacode/rescript-react-on-rails-example 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is