Rename CypressDev to CypressOnRails #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@justin808 can you enable travis-ci for the project please |
yagudaev
approved these changes
Jun 18, 2019
| @@ -202,7 +202,7 @@ add the following file to cypress | |||
|
|
|||
| ```js | |||
| // test/cypress/support/on-rails.js | |||
There was a problem hiding this comment.
should the file itself be called cypress-on-rails?
cypress-on-rails.gemspec
Outdated
| s.author = ["miceportal team", 'Grant Petersen-Speelman'] | ||
| s.email = ["[email protected]", '[email protected]'] | ||
| s.homepage = "http://github.com/grantspeelman/cypress-on-rails" | ||
| s.summary = "Integrates cypress with rails or rack applications" | ||
| s.description = "Integrates cypress with rails or rack applications" | ||
| s.post_install_message = 'The CypressDev constant is being deprecated and will be completely removed and replaced with CypressOnRails' |
|
|
|
Tested the branch on our CI with only updating the gem and it works without any additional changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as mentioned in #17 and #11