Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
The demo tests occasionally timeout, in spite of being synchronous test cases. This is because of an async teardown process between tests, which can sometimes hang. This may indicate some condition in which player.destroy() could hang, though I have been unable to replicate that hypothetical condition in an explicit unit test. The hang goes away if we don't attach to the video element. Since the tests don't use the video element directly or attempt to load any content, we can just skip the video element attachment. Another thing that appears to resolve the hang is to await attach(), so a comment has been left to warn anyone modifying the code in the future not to use the constructor argument to attach a video element.
- Loading branch information