Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging using morgan #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

miniBill
Copy link

This adds a dependency, so I'm not sure if you'd like it for the template, but I think it's useful to have logging of the requests

@shahnhogan
Copy link
Owner

Thanks for the PR! Adding logging with morgan is definitely useful in many projects.

For elm-pages-starter-express, I want to keep things as lightweight and flexible as possible so developers can choose tools based on folks' needs. While morgan is a solid choice, I’m aiming to avoid adding specific dependencies unless they’re absolutely necessary for most users.

Feel free to use morgan or any other logging solution in your setup. I use pino in my production setup and it's worked great. I'll leave this PR open for now to see if others think logging should be a part of the project.

Thanks again for contributing!

@miniBill
Copy link
Author

Yeah, I split my edits into multiple PRs so you could pick the uncontroversial stuff and then we can talk about the less obviously needed ones 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants