Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scalable vector redraw of shadps4 icon #1501

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

fpiesche
Copy link
Contributor

@fpiesche fpiesche commented Nov 7, 2024

This is a freely-scalable source file that could also easily be used for other icon bases. The icon does not fill the entire canvas to follow the FreeDesktop project's quality guidelines.

This PR is a version of #1494 without the mess I made of the commit history over there...

@ngoquang2708
Copy link
Contributor

Please add an entry to the image in the REUSE.toml.

@fpiesche fpiesche force-pushed the add-svg-icon branch 4 times, most recently from b3e1fbb to f62bb55 Compare November 9, 2024 18:45
Copy link

@jardon jardon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jardon
Copy link

jardon commented Nov 10, 2024

actually this isnt a super noticable thing, but the right side of the "O" is a little messed up. idk if its trivial to fix

@ngoquang2708
Copy link
Contributor

actually this isnt a super noticable thing, but the right side of the "O" is a little messed up. idk if its trivial to fix

Good catch.

@fpiesche
Copy link
Contributor Author

It was trivial to fix, just a matter of me having set the wrong stroke style on the circle. Good spot, and it's also made me realise I still had a full copy of the .png icon in there from drawing the svg over it! That'll massively reduce the file size on this too :D

@georgemoralis georgemoralis merged commit 85f45d2 into shadps4-emu:main Nov 12, 2024
10 checks passed
fpiesche added a commit to fpiesche/shadPS4 that referenced this pull request Nov 12, 2024
* Add scalable vector redraw of shadps4 icon

* Update icon name in desktop file

* Fix svg
fpiesche added a commit to fpiesche/shadPS4 that referenced this pull request Nov 12, 2024
* Add scalable vector redraw of shadps4 icon

* Update icon name in desktop file

* Fix svg
fpiesche added a commit to fpiesche/shadPS4 that referenced this pull request Nov 12, 2024
* Add scalable vector redraw of shadps4 icon

* Update icon name in desktop file

* Fix svg
fpiesche added a commit to fpiesche/shadPS4 that referenced this pull request Nov 12, 2024
* Add scalable vector redraw of shadps4 icon

* Update icon name in desktop file

* Fix svg
@fpiesche fpiesche deleted the add-svg-icon branch November 12, 2024 16:20
@@ -941,4 +941,5 @@ install(TARGETS shadps4 BUNDLE DESTINATION .)
if (ENABLE_QT_GUI AND CMAKE_SYSTEM_NAME STREQUAL "Linux")
install(FILES ".github/shadps4.desktop" DESTINATION "share/applications")
install(FILES ".github/shadps4.png" DESTINATION "share/icons/hicolor/512x512/apps")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 512x512 icon should have the same name as the scalable one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1495 includes a change to make that happen :)

fpiesche added a commit to fpiesche/shadPS4 that referenced this pull request Nov 14, 2024
* Add scalable vector redraw of shadps4 icon

* Update icon name in desktop file

* Fix svg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants