-
-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scalable vector redraw of shadps4 icon #1501
Conversation
Please add an entry to the image in the |
b3e1fbb
to
f62bb55
Compare
f62bb55
to
d97a597
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
actually this isnt a super noticable thing, but the right side of the "O" is a little messed up. idk if its trivial to fix |
Good catch. |
It was trivial to fix, just a matter of me having set the wrong stroke style on the circle. Good spot, and it's also made me realise I still had a full copy of the .png icon in there from drawing the svg over it! That'll massively reduce the file size on this too :D |
* Add scalable vector redraw of shadps4 icon * Update icon name in desktop file * Fix svg
* Add scalable vector redraw of shadps4 icon * Update icon name in desktop file * Fix svg
* Add scalable vector redraw of shadps4 icon * Update icon name in desktop file * Fix svg
* Add scalable vector redraw of shadps4 icon * Update icon name in desktop file * Fix svg
@@ -941,4 +941,5 @@ install(TARGETS shadps4 BUNDLE DESTINATION .) | |||
if (ENABLE_QT_GUI AND CMAKE_SYSTEM_NAME STREQUAL "Linux") | |||
install(FILES ".github/shadps4.desktop" DESTINATION "share/applications") | |||
install(FILES ".github/shadps4.png" DESTINATION "share/icons/hicolor/512x512/apps") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 512x512 icon should have the same name as the scalable one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#1495 includes a change to make that happen :)
* Add scalable vector redraw of shadps4 icon * Update icon name in desktop file * Fix svg
This is a freely-scalable source file that could also easily be used for other icon bases. The icon does not fill the entire canvas to follow the FreeDesktop project's quality guidelines.
This PR is a version of #1494 without the mess I made of the commit history over there...