-
-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Added threading to AJM #1460
Conversation
hint: try it on your own risk |
e18b234
to
e7d9c5c
Compare
for Bloodborne both main menu OST and menu sound effects play very consistently with this, but after going ingame and transforming weapon it crashes instantly, for some reason without an assert it can also hang randomly during ingame load, not sure if related to these changes |
Build e7d9c5c My run was about 2 minutes, then a crash. Edit: I will add 2024-10-29.23-47-22.mp4 |
I tried to play a few more times, but I can't pass the "ascend ladder" moment, somewhere in the middle of this ladder there is always a crash. Sometimes I manage to hear the cry of a Cleric Beast, and sometimes I don't. And it seems that for the first time I had an error: [Debug] ajm_at9.cpp:operator():70: Assertion Failed! |
Tried it with Persona 3 Dancing Moonlight and the dlc confermation dialog now has sound :D but it crashes at the title screen with
|
e7d9c5c
to
791e011
Compare
Fixed one reason of crashes try again. |
Not sure if it was expected to be fixed or not but the Persona 3 Dancing crash is still the same. |
Build a548249 "Ascend ladder" moment - FIXED, done. BB_Test.mp4Then I activated the lamp, but I couldn't get into Hunter's Dream, there was no crash, but it was as if everything went into an endless loop, the loading of the location hung, but shad_log continued, I waited about a minute and closed the emulator. Shad_log size 100 MB (therefore, I will not attach the file), but it seems like these lines were repeated
I couldn't test this before, but in this build, I personally don't have a crash. 2024-10-30.22-29-25.mp4And another such moment: Other games have music here, but Bloodborne doesn't, I don't know if it should be like that. Later, I will test this build again, if there is anything else, I will write. |
791e011
to
12db492
Compare
Build tested: a8f0da6. BB-Patches: Skip Intro, Disable Chromatic Ab, Disable Motion Blur, 60 FPS (with Delta time), Disable vsync In general, I would say that when it works, it just works fine. I got a couple of crashes, specially when returning to Hunter's dream and once whilst getting ambushed, when that happens it seems like there are some thread deadlocks (console spamming i.e. sceAjmBatchWait). Some people said that this AJM Branch does not work with the 60 FPS patch applied, but my experience has been quite good. I do not see much of a difference between both 30 FPS and 60 FPS. The biggest problem was with Cleric Beast's BGM, either starts looping like a broken record at some point, or does not play at all. Reloading or repeating this fight does NOT solve this problem. Apart from that, at first glance I am not missing any other regular sounds. |
Build a8f0da6 The first lighting of the lamp and the subsequent transfer to the Hunter's Dream did not work again, it loops (freezes) during the download. (There is a similar hanging moment in one of the videos below) In the Hunter's Dream, Herman's lines worked fine, Gil3.mp4Then there was this: Gilbert444.mp4The loading stopped, but the emulator continued to work. Restarted the emulator. 2024-10-31.13-01-56.mp4Next 2024-10-31.13-05-59.mp4Next is a large gate, through which Huntsman's Minion breaks. Gate.mp42024-10-31.13-25-47.mp4Then there was a moment when, right during the battle, the sound abruptly disappeared. Next House.mp4House2.mp4Perhaps something in the house affects this area, for example, an NPC, because once there was a freeze, and another time the sound disappeared. Then I attach screenshots of the log. I don't know if they are all related to these PR or not: In the log, it happened that the "AJM-log" simply stopped and only the "Kernel-log" continued. I played for about an hour, I didn't visit the bosses. |
Before Cleric Beast (There is some kind of noise) 2024-10-31.17-19-05.mp4Cleric Beast (The noise remains, the musical theme is missing) Cleric.Beast.mp4Father Gascoigne (Everything seems to be in order here) Father.Gascoigne.mp4Father Gascoigne's daughter, The Doll, Eileen the Crow, Gehrman, The First Hunter - their lines were playing normally. I went to Gilbert's house again to take the flamesprayer from him after defeating the Cleric Beast. Gilbert.4.mp4Chapel Samaritan in Cathedral Ward also broken: Chapel.Samaritan.mp4I didn't play anymore. |
* ajm: Initial ajm implementation * AJM code improvements (#1453) * Fix sideband buffer order (#1454) * ajm: Attempt to add gapless support * ajm_at9: Return superframes decoded in a single job * WIP (#1460) * Fix gapless decode and combine split buffers * Fixed linux build * fix number of samples reported with gapless decoding * fixed number of remaining samples calculation should fix the small crackling sounds that play every now and again * refactor half ajm * refactored most of ajm * refactored ajm * clang-format, in-repo libatrac9, removed debug stuff --------- Co-authored-by: auser1337 <[email protected]> Co-authored-by: Vladislav Mikhalin <[email protected]> Co-authored-by: IndecisiveTurtle <[email protected]>
Very dirty code, needs a LOT of work.