Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F fix j0 pos vel filter #211

Open
wants to merge 7 commits into
base: noetic-devel
Choose a base branch
from
Open

F fix j0 pos vel filter #211

wants to merge 7 commits into from

Conversation

carebare47
Copy link
Contributor

Proposed changes

Please explain the changes you made. Add pictures or videos to explain them better if appropriate.

Checklist

Before posting a PR ensure that from each of the below categories AT LEAST ONE BOX HAS BEEN CHECKED. If more than one category is applicable then more can be checked. Also ensure that the proposed changes have been filled out with relevant information for reviewers.

Tests

  • No tests required to be added. (For small changes that will be tested by CI/CD infrastructure).
  • Added/Modified automated and PhantomHand CI tests (if a new class is added (Python or C++), the interface of that class must be unit tested).
  • Manually tested in simulation (if simulation specific or no hardware required to test the functionality).
  • Manually tested on hardware (if hardware specific or related).

Documentation

  • No documentation required to be added.
  • Added documentation (For any new feature, explain what it does and how to use it. Write the documentation in a relevant space, e.g. Github, Confluence, etc).
  • Updated documentation (For changes to pre-existing features mentioned in the documentation).

guihomework and others added 5 commits April 22, 2021 15:45
@guihomework
Fixed timeout in python test (#169) and reduced CPU load while waiting (
65e9866 
#170)
@guihomework
Fix#171 handfinder ns (#173)
a761d51 
* Fixing hand finders to support namespace

* Additional fix of the same namespace problem
@guihomework
B#171 handfinder ns (#172)
5f24b8b 
* Fixing sr_utilities tests to handle namespaced tests

* Added namespaced test to sr_utilities
@toliver
Fixing J0 (J1 and J2) position and velocity filter
78b8366
@toliver
Merge branch 'melodic-devel' of github.com:shadow-robot/sr_core into …
0bf2a85 
…F_fix_J0_pos_vel_filter
@carebare47 carebare47 requested review from a team as code owners April 4, 2022 10:34
carebare47 and others added 2 commits May 13, 2022 09:52
@carebare47 @toliver @bdenoun
F improve realtime publisher fast pid divisor (#213)
1bb2bc7 
* Copy realtime publisher to sr_core

* Change priority of the realtime publisher thread to be equal to maximum - 10

* Adding buffers. Not compiling yet.

* sh_joint_effort_controller is now using the new circular buffer

* New joint_state_contrller that uses the circular buffers and the new realtime_publisher

* remove publish rate divider for data recording

* adding faster rt pubs to position controlers

* setting deadband average from 50 to 1

* adding divisor

Co-authored-by: Toni Oliver <[email protected]>
Co-authored-by: carebare47 <[email protected]>
Co-authored-by: Brice <[email protected]>
@carebare47
Merge branch 'F_data_collection_fixed_j0_filters_and_fast_rt_pubs_and…
069c728 
…_effort_filters' into F_fix_J0_pos_vel_filter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carebare47 @guihomework @toliver