Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SPIRV integer vector dot product instructions #6141

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use SPIRV integer vector dot product instructions #6141

wants to merge 3 commits into from

Conversation

fairywreath
Copy link
Contributor

Closes #6135.

Use SPIRV OpUDot/OPSDot instructions from the DotProduct capability to implement dot.

@fairywreath fairywreath requested a review from a team as a code owner January 21, 2025 05:56
csyonghe
csyonghe previously approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@csyonghe csyonghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@csyonghe csyonghe added the pr: non-breaking PRs without breaking changes label Jan 21, 2025
@fairywreath fairywreath requested a review from csyonghe January 21, 2025 22:19
aleino-nv
aleino-nv approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@aleino-nv aleino-nv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

(Aside: I think OpUDot and OpSDot would both work the same in the case where the operands are vectors (not packed) and the return type T is the same as both operand scalar types, but it doesn't hurt to distinguish AFAIK).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleino-nv aleino-nv aleino-nv approved these changes

@csyonghe csyonghe Awaiting requested review from csyonghe

Assignees
No one assigned
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use OpUDot/OpSDot for SPIRV
3 participants
@fairywreath @csyonghe @aleino-nv