fix(shadcn): Select asChild prop is unsupported

[lime517]

Summary of issue

Using the <SelectTrigger> component with the asChild prop results in the following error:

Error: React.Children.only expected to receive a single React element child.

This is due to the <ChevronDown> icon being included as second descendant of <SelectTrigger>, even when asChild is TRUE. asChild requires that there is only one descendant.

Solution

Conditionally render <ChevronDown> inside a fragment that includes {children} if props.asChild is not set. If props.asChild is set, then simply render {children}. There are no visual changes with this solution.

Notes

This is my first contribution to shadcn/ui - let me know if I'm missing any details! I could not find any existing issue reports for this.

[vercel]

Someone is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

[branxy]

I'd like to mention there's a related issue on this in radix-ui repo: folks in the comments arrived at the same conclusion that the current solution should be to conditionally render the icon.