Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum Dask dependency versions #1111

Closed
wants to merge 5 commits into from

Conversation

tomwhite
Copy link
Collaborator

  • Fixes #xxxx
  • Tests added
  • User visible changes (including notable bug fixes) are documented in changelog.rst
  • New functions are listed in api.rst

@tomwhite
Copy link
Collaborator Author

Restricting to pandas < 2 fixes the problem on Windows, but I'm not sure what the underlying problem is. It would be nice to know what that is to see if it could be fixed in a less restrictive way.

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2023

Codecov Report

Merging #1111 (d334152) into main (cc04858) will not change coverage.
The diff coverage is n/a.

❗ Current head d334152 differs from pull request most recent head 631662a. Consider uploading reports for the commit 631662a to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff            @@
##              main     #1111   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           50        50           
  Lines         5054      5054           
=========================================
  Hits          5054      5054           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tomwhite
Copy link
Collaborator Author

I haven't been able to diagnose the underlying problem, so I tried to only add the pandas < 2 restriction to Windows with the following in requirements.txt:

pandas; platform_system != "Windows"
pandas < 2; platform_system == "Windows"

This is valid for Pip, but not Conda, which we use for (part of) the Windows installation, since msprime wheels are not available on Windows.

I'm not sure how to make progress with this.

@tomwhite
Copy link
Collaborator Author

BTW this PR is to fix #1109

@tomwhite
Copy link
Collaborator Author

tomwhite commented Sep 5, 2023

Closed in favour of #1122

@tomwhite tomwhite closed this Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants