Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retarded 3D Green's function uniformly moving point source #75

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

fietew
Copy link
Member

@fietew fietew commented Mar 11, 2016

to test:
sound_field_mono([-2,2],[-2,2],0,[0,1,0,100,0,0,1],'mps',1,1000,conf)

TODO:
for the moment, i had to deactivate the check for the secondary sources' orientation vector to be normalized, as the velocity of the moving source is encoded in the magnitude of the sound source. Any ideas regarding a good solution?

@hagenw
Copy link
Member

hagenw commented Mar 11, 2016

I see at least two easy solutions:

  1. Use a conf entry for the velocity
  2. Disable the checking of nx0 and ensure that nx0 is really a direction vector at those places where it has to be one (for example by using direction_vector(nx0))

Any preference for one of the two solutions?

@fietew
Copy link
Member Author

fietew commented Mar 11, 2016

2nd solution seems to be the better one as we should avoid additional entries in the conf struct if possible.

@hagenw
Copy link
Member

hagenw commented Mar 11, 2016

Yes, I'm also in favor of the 2nd solution. The only downside is that it will probably affect a lot of files.

Do you also plan to add a time-domain version of the moving source, or will this be to complicated?

Fiete Winter and others added 6 commits May 10, 2016 20:28
* master:
  Update copyright owner to SFS Toolbox Developers
  Update README for online documentation
  Remove wavread and wavwrite (#81)
  Return delay offset from delayline() (#82)
  New Handling of delayline and fractional delay (#50)
  Fix dos line endings
  Update comments for SSR BRS
  Update license in missing files
  Change license to MIT (#80)
  Make direction_vector() work with matrix => vector
  add modal weighting to time-domain nfchoa (#77)
  Fix comment of tapering_window()
  Add automatic scaling to loudspeaker weights for plotting (#78)
  Update comment of interpolation()
  Update NEWS
  Fix interpolation calling bug in interpolation_ir()
  Remove debugging parameter
  Fix normalization for 2D interpolation
  Further improvements to description of interpolation()
  Enhance description for interpolation()

Conflicts:
	SFS_general/direction_vector.m
@fietew
Copy link
Member Author

fietew commented Jun 8, 2016

The time-domain version would require time-variant convolution and time-variant driving signals. This would require a complete new component in the toolbox. So far, I have no idea, how this could be included in the current framework.

@hagenw
Copy link
Member

hagenw commented Feb 15, 2019

Should we include then only the monochromatic version. I don't see that we develop the time domain version at the moment.

@fietew
Copy link
Member Author

fietew commented Feb 18, 2019

So we remove the check for the direction of the secondary sources?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants