Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix fromsql for domains #1189

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix fromsql for domains #1189

wants to merge 2 commits into from
+37 −1

Conversation

zacknewman
Copy link

Fixes #1188.

@sfackler
Copy link
Owner

Can you add a test for the case that was failing before this fix?

@zacknewman
Copy link
Author

Added a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unreachable code entered when SELECTing nested composite types and DOMAINs
2 participants
@zacknewman @sfackler