Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper to return &mut SslRef from stream #2223

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jmayclin
Copy link
Contributor

Currently there is no way to retrieve a mutable reference to the underlying SslRef given some SslStream. This PR adds an ssl_mut method to do that.

@jmayclin
Copy link
Contributor Author

There is a failure in the CI, but it looks to be unrelated to my PR.

error: package `cc v1.0.95` cannot be built because it requires rustc 1.63 or newer, 
while the currently active rustc version is 1.56.0

cc bumped their MSRV in the latest release (3 days ago): https://github.com/rust-lang/cc-rs/releases/tag/1.0.95, which appears to be the reason for this failure.

@botovq
Copy link
Contributor

botovq commented Apr 28, 2024

CI should be fixed once you rebase on main

@jmayclin
Copy link
Contributor Author

Hi @alex, wondering if you could take a look at this? Thanks!

@alex
Copy link
Collaborator

alex commented May 13, 2024

Unfortunately I don't use the ssl layer of this package, only the libcrypto parts, so I'm not familiar with this part of the code or the semantics to know if this raises any potential issues.

@jmayclin
Copy link
Contributor Author

Ah, I understand. Do you know how I could go about getting this reviewed?

@alex
Copy link
Collaborator

alex commented May 13, 2024 via email

@jmayclin
Copy link
Contributor Author

Hi @sfackler, I am still interested in getting this merged in. Please let me know if you have any feedback or concerns!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants