-
-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend X509Crl functionality #2174
base: master
Are you sure you want to change the base?
Conversation
7fbc2ee
to
45534ac
Compare
8707772
to
9cf4429
Compare
0ed91d2
to
923783c
Compare
923783c
to
b44bcc5
Compare
add optional config paramter; fix erroneous CRL version; add AuthorityKetIdenfier extension when building CRLv2; set_crl_number is now private; increment_crl_number is the new public interface, returning the new crl value, or None if self is a CRLv1; update tests using X509Crl::new
6e38a04
to
3e4fbdb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Yes, this is OpenSSL 1.1 API. All this should be available since 2.8.1.
I have only looked at the cfg parts.
974f466
to
974a8d8
Compare
pub fn revoke(&mut self, to_revoke: &X509) -> Result<(), ErrorStack> { | ||
match self.get_by_cert(to_revoke) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When my PR #2207 is merged, you can change this &X509
to &X509Ref
as well.
pub fn revoke(&mut self, to_revoke: &X509) -> Result<(), ErrorStack> { | |
match self.get_by_cert(to_revoke) { | |
pub fn revoke(&mut self, to_revoke: &X509Ref) -> Result<(), ErrorStack> { | |
match self.get_by_cert(to_revoke) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I will update it once it is merged.
@botovq do you see any further issues with this PR? (since you haven't approved it yet 😅) |
Asn1Time
usage example