Remove module-info.java
#33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NebelNidas
force-pushed
the
remove-module-info
branch
2 times, most recently
from
24c6af9
to
b06b3b9
Compare
Draft
NebelNidas
force-pushed
the
remove-module-info
branch
from
f73a977
to
6e5d676
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's annoying to deal with, most libraries don't support it out of the box, and once you build Matcher, the shadow plugin removes it anyway. So it's not of any benefit to us, other than potentially limiting plugins' access to Matcher internals, but as made apparent by similar discussions regarding Fabric Loader, that's not intended anyway.
For any other potential JPMS-compliant applications depending on Matcher, I did include a
Automatic-Module-Namemanifest entry though, identical to the current one.