Fix potential crash after loading of saved game #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sezero
reviewed
Aug 14, 2023
when number of edicts parsed from saved game is smaller than `sv.num_edicts`, "old" edicts are not freed nor unlinked while their memory can be reused by newly spawned entities fix sezero#64
alexey-lysiuk
force-pushed
the
fix_loadgame_crash
branch
from
6603538
to
5dd8f36
Compare
sezero
approved these changes
Aug 14, 2023
matthewearl
added a commit
to matthewearl/JoeQuake-1
that referenced
this pull request
Aug 16, 2023
This is a port of alexey.lysiuk's fix for QuakeSpasm:
5dd8f36a13d4366fff1e64add708d1b77e9ffff3
sezero/quakespasm#75
Observed by me in ironwail and also JQ reloading a savegame at the start
of e1m6:
andrei-drexler/ironwail#242
|
This patch is in now. Thanks! |
andrei-drexler
pushed a commit
to andrei-drexler/ironwail
that referenced
this pull request
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When number of edicts parsed from saved game is smaller than
sv.num_edicts, "old" edicts are not freed nor unlinked while their memory can be reused by newly spawned entities.This commit fixes #64.