Issue #461: Field single declaration check implemented #811
Conversation
| final DetailAST findFirstToken = ast.findFirstToken(TokenTypes.TYPE); | ||
| final FullIdent ident = CheckUtil.createFullType(findFirstToken); |
There was a problem hiding this comment.
Not sure if we should test findFirstToken and ident against NPE. A variable definition should always have a TYPE and IDENT right ?
There was a problem hiding this comment.
Regression would should if an exception is possible.
yaziza
force-pushed
the
461-field-declaration-count
branch
4 times, most recently
from
7e6921b
to
7cd43be
Compare
yaziza
force-pushed
the
461-field-declaration-count
branch
from
7cd43be
to
e66589d
Compare
|
Unfortunately, i was not able to fix the build of
Any hint ? |
A PR to contribution report has to be made to add the check. It can only be merged after this PR is merged, so as long as it is the only error, it is fine for it to stay. |
| public void visitToken(DetailAST ast) { | ||
| if (SevntuUtil.matchesFullyQualifiedName(ast, fullyQualifiedClassName)) { | ||
| if (hasPreviouslySeenClass) { | ||
| log(ast.getLineNo(), MSG_KEY, fullyQualifiedClassName); |
There was a problem hiding this comment.
Please give it the full AST.
|
|
||
| @Override | ||
| public int[] getDefaultTokens() { | ||
| return new int[] {TokenTypes.VARIABLE_DEF }; |
There was a problem hiding this comment.
I don't see this being enough. You are not checking imports so your implementation is very susceptible to name conflicts.
|
@yaziza ping |
#461