Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: rename misleading property #770

Closed
wants to merge 1 commit into from
Closed

minor: rename misleading property #770

wants to merge 1 commit into from

Conversation

pzygielo
Copy link
Contributor

@pzygielo pzygielo commented Jul 27, 2019

As discussed below, I believe this property is used only to control version of CS itself.

Copy link
Contributor

@rnveach rnveach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pzygielo Github is marking this as a draft.
I also don't feel newprop is a better name for this option. eclipse-cs clearly tells us it is the version number for eclipse-cs which we rely on.

@pzygielo
Copy link
Contributor Author

pzygielo commented Jul 27, 2019

@pzygielo Github is marking this as a draft.

I did it.

I also don't feel newprop is a better name for this option.

It's not, hence draft.

eclipse-cs clearly tells us it is the version number for eclipse-cs which we rely on.

It's not.

@pzygielo
Copy link
Contributor Author

pzygielo commented Jul 27, 2019

I might not see it, but I think it's only here

git checkout 8.12.0

and
<eclipsecs.version>8.12.0-SNAPSHOT</eclipsecs.version>

that eclipse-cs is used, and the version is hardcoded anyway.

In other cases it's simply CS version. At least as I see it, which might be wrong of course.

@pzygielo pzygielo marked this pull request as ready for review July 27, 2019 13:48
@pzygielo
Copy link
Contributor Author

Closing due to comment

New property name is very misleading

Got it.

@pzygielo pzygielo closed this Jul 27, 2019
@pzygielo pzygielo deleted the rename_property branch July 27, 2019 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants