Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken discovery sites #1005

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Bananeweizen
Copy link
Contributor

Discovery sites are used by the p2 installation system to discover additional update sites containing eclipse plugins and features. Adding arbitrary websites as discovery sites is an error and will lead to the Eclipse update mechanism trying to interpret those websites as update sites, failing, and then adding error messages in the log on each update.

<feature
id="com.github.sevntu.checkstyle.checks.feature"
label="Extension for eclipse-cs plugin with additional Checks"
version="1.44.1">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can only assume the other changes are valid since I don't know, but I noticed when changing the formatting of these line were undone during a release by the release process. I don't know why they were, but I assume they have to remain as they were before unless we can disable the process that re-modified this file.

See #960
The release command that did this is mvn -e --no-transfer-progress clean install -f eclipse-pom.xml -Plocal-deploy.

</url>

<plugin id="eclipsecs-sevntu-plugin" download-size="0" install-size="0" version="1.44.1" unpack="false"/>
<plugin
id="eclipsecs-sevntu-plugin"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with splitting this among multiple lines.

@rnveach
Copy link
Contributor

rnveach commented Apr 12, 2023

Test failure is commit message. I would rename commit to infra: removed broken discovery sites and put any extra text you put in the commit message to the PR's first post.

Discovery sites are used by the p2 installation system to discover
additional update sites containing eclipse plugins and features. Adding
arbitrary websites as discovery sites is an error and will lead to the
Eclipse update mechanism trying to interpret those websites as update
sites, failing, and then adding error messages in the log on each
update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants