improved property id generation for tagging

seung-lab · Sep 23, 2024 · 8be7d30 · 8be7d30
1 parent d043b4b
commit 8be7d30
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/annotation/index.ts b/src/annotation/index.ts
@@ -1312,6 +1312,20 @@ export class LocalAnnotationSource extends AnnotationSource {
     );
   }
 
+  getUniquePropertyId() {
+    const { properties } = this;
+    const ids = new Set<string>();
+    for (const p of properties.value) {
+      ids.add(p.identifier);
+    }
+    while (true) {
+      const uuid = crypto.randomUUID();
+      if (!ids.has(uuid)) {
+        return uuid;
+      }
+    }
+  }
+
   addProperty(property: AnnotationPropertySpec) {
     this.properties.value.push(property);
     for (const annotation of this) {

diff --git a/src/layer/annotation/index.ts b/src/layer/annotation/index.ts
@@ -535,7 +535,7 @@ class TagsTab extends Tab {
                   enumLabels: ["", value],
                   default: 0,
                   description: value,
-                  identifier: self.crypto.randomUUID(), // TODO
+                  identifier: localAnnotations.getUniquePropertyId(),
                 });
               }
             }