Skip to content
This repository has been archived by the owner on Nov 12, 2022. It is now read-only.

Adds getting started docs for macOS #413

Merged
merged 1 commit into from
Mar 28, 2018
Merged

Adds getting started docs for macOS #413

merged 1 commit into from
Mar 28, 2018

Conversation

anthgur
Copy link
Contributor

@anthgur anthgur commented Mar 26, 2018 •
edited by larsbergstrom
Loading

This change is Reviewable

atouchet
atouchet reviewed Mar 26, 2018
View reviewed changes
README.md Outdated
### Other dependencies

#### OS X
#### On OS X (homebrew)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apple no longer uses the OS X branding. Can these be changed to say macOS instead? Also I think homebrew should be capitalized here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@anthgur anthgur changed the title Adds getting started docs for OS X Adds getting started docs for macOS Mar 26, 2018
jdm
jdm suggested changes Mar 26, 2018
View reviewed changes
README.md Outdated

### Rust

This project requires Rust nightly-2018-03-25 or greater. You can install this with Rustup.rs:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it makes sense to repeat the rustup installation instructions here. It's more efficient to direct people to https://rustup.rs/.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense, can we keep the nightly info though? I spent some time figuring out I needed to use nightly instead of stable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's fine.

@anthgur anthgur force-pushed the getting_started_osx branch from 7a5133f to 94b987a Compare March 26, 2018 22:34
@anthgur anthgur force-pushed the getting_started_osx branch from 94b987a to 1090c26 Compare March 26, 2018 22:35
@jdm
Copy link
Member

jdm commented Mar 27, 2018

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 1090c26 has been approved by jdm

@bors-servo
Copy link
Contributor

⌛ Testing commit 1090c26 with merge e6fd96c...

bors-servo pushed a commit that referenced this pull request Mar 27, 2018
Auto merge of #413 - anthgur:getting_started_osx, r=jdm
e6fd96c 
Adds getting started docs for macOS

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/413)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - status-appveyor

@jdm
Copy link
Member

jdm commented Mar 27, 2018

@bors-servo retry

@bors-servo
Copy link
Contributor

⌛ Testing commit 1090c26 with merge de310c8...

bors-servo pushed a commit that referenced this pull request Mar 27, 2018
Auto merge of #413 - anthgur:getting_started_osx, r=jdm
de310c8 
Adds getting started docs for macOS

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/413)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💥 Test timed out

@jdm
Copy link
Member

jdm commented Mar 28, 2018

@bors-servo retry

@bors-servo
Copy link
Contributor

⌛ Testing commit 1090c26 with merge 5a83ac8...

bors-servo pushed a commit that referenced this pull request Mar 28, 2018
Auto merge of #413 - anthgur:getting_started_osx, r=jdm
5a83ac8 
Adds getting started docs for macOS

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/413)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: jdm
Pushing 5a83ac8 to master...

@bors-servo bors-servo merged commit 1090c26 into servo:master Mar 28, 2018
@bors-servo bors-servo mentioned this pull request Mar 28, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@atouchet atouchet atouchet left review comments

@jdm jdm jdm requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anthgur @jdm @bors-servo @atouchet