Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #553 #555

Merged
merged 3 commits into from
Mar 10, 2024
Merged

Fix #553 #555

merged 3 commits into from
Mar 10, 2024

Conversation

s3bk
Copy link
Collaborator

@s3bk s3bk commented Feb 15, 2024

This replaces two unwraps with Results and makes PFCanvasSetFontByPostScriptName return an i32 to indicate success or failure.
Intended to fix #553

jayvdb
jayvdb approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@jayvdb jayvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just noting that these are breaking changes, but better done sooner than later

@s3bk
Copy link
Collaborator Author

s3bk commented Feb 18, 2024

Yea. This isn't really possible without breaking existing code.
I modified it a bit so the underlying errors are available and the unwrap() works.

@s3bk
Copy link
Collaborator Author

s3bk commented Mar 5, 2024

@jayvdb can you review it again?

@s3bk s3bk enabled auto-merge March 5, 2024 12:17
@s3bk s3bk added this pull request to the merge queue Mar 10, 2024
Merged via the queue into servo:main with commit 30419d0 Mar 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm jdm approved these changes

@jayvdb jayvdb jayvdb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panicking when font is not found or can't be loaded
3 participants
@s3bk @jayvdb @jdm