-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mutability from parser/tokenizer APIs. #548
Conversation
FYI @Taym95 |
Thanks, Should I close the other PR? lets me knew is you need help here in clean up. |
html5ever/src/macros.rs
Outdated
Some(x) => x, | ||
{ | ||
let Some(x) = $opt else { $else_block }; | ||
x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is necessary to minimize the scope of refcell borrows that are passed as arguments to the macro.
We can still merge the other PR, but we should remove all uses of |
5858c9b
to
6165801
Compare
Ok, the code's cleaned up and commits are split into:
|
@Taym95 Would you like to review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed all the changes, and everything looks good to me!
This is incompatible with a re-entrant parsing algorithm which is required by the web platform's document.write API.