Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid msg_send! #702

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Fix invalid msg_send! #702

merged 1 commit into from
Aug 13, 2024

Conversation

madsmtm
Copy link
Contributor

@madsmtm madsmtm commented Aug 12, 2024

Extracted from #628 as per request in #628 (review).

@madsmtm madsmtm mentioned this pull request Aug 12, 2024
Open
waywardmonkeys
waywardmonkeys approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@waywardmonkeys waywardmonkeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are all correct according to my (sometimes limited) understanding.

cocoa-foundation/src/foundation.rs Show resolved Hide resolved
cocoa-foundation/src/foundation.rs Show resolved Hide resolved
cocoa/src/quartzcore.rs Show resolved Hide resolved
@waywardmonkeys waywardmonkeys added this pull request to the merge queue Aug 13, 2024
@waywardmonkeys
Copy link
Contributor

@madsmtm Thanks!

Merged via the queue into servo:main with commit 6541d9a Aug 13, 2024
8 checks passed
@madsmtm madsmtm deleted the fix-invalid-msg-sends branch August 13, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waywardmonkeys waywardmonkeys waywardmonkeys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madsmtm @waywardmonkeys