Expose the CTFont-creation functions with options parameter
#636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrmuizel
approved these changes
Sep 19, 2023
|
@jfkthame The rustfmt job is failing. Can you fix it? |
|
Hmm, it looks like rustfmt commit didn't make it in. (I still don't quite understand how the github merge bot works) |
|
Yeah, I saw that. :( Maybe because it hadn't been reviewed? Not sure what the best way to clean up would be - do we need to make a new PR just for the formatting? |
|
I don't know how to do a followup here (if it's possible at all), so I simply opened a new PR #637 for the rustfmt fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.