Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing parameter, change incorrect member variable name #91

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

hampuslavin
Copy link
Contributor

Fixes:

  • Missing session parameter in updateRow call
  • Unless I'm missing something, the member variable referenced in the docs, authorizedUserId, doesn't exist (anymore)?
    • I changed it to authenticatedUserId which is the existing one
    • Is this just a typo and should I change it in all versions of the docs? Or was this a breaking change at some point?

Copy link
Contributor

@SandPod SandPod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct, authorizedUserId doesn't exist.
And I can't seem to find it in any of the older tags of the repo either so feel free to change on all version back to 1.0.0 (before that we don't have a tag so I'm not sure if it change names back then).

I'll approve and merge once the change is applied to 1.1.0 and 1.0.0

Thank you for the corrections 🙏

@SandPod SandPod self-requested a review April 22, 2024 06:40
Copy link
Contributor

@SandPod SandPod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too quick on the trigger. Apply the authorizedUserId change on 1.1.0 and 1.0.0 and I'll approve and merge :)

@hampuslavin
Copy link
Contributor Author

@SandPod Done! ✅

Copy link
Contributor

@SandPod SandPod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix! 🙏

@SandPod SandPod merged commit 94e1232 into serverpod:main Apr 25, 2024
1 check passed
@hampuslavin hampuslavin deleted the hl/fix-typo-in-users branch April 25, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants