Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add section around how to set up custom authentication integration. #86

Merged
merged 7 commits into from
Mar 28, 2024

Conversation

SandPod
Copy link
Contributor

@SandPod SandPod commented Mar 28, 2024

Adds a section explaining how to implement a custom authentication integration.

After review this addition should be added to the versioned docs so that it is available directly.

@SandPod SandPod force-pushed the custom-authentication-implementation branch from c535411 to 3ca629b Compare March 28, 2024 10:05
Copy link
Contributor

@vlidholt vlidholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall super good, but it is a bit unclear what you have to do to create your own authentication and what you can do.

It would be nice to include a little bit on how to hook this up with the UserInfo class in the auth module too (as this will be the most common use case).

Copy link
Contributor

@vlidholt vlidholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@vlidholt vlidholt merged commit a993a32 into main Mar 28, 2024
1 check passed
@SandPod SandPod deleted the custom-authentication-implementation branch August 15, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants