Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document the sealed feature #194

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

BenAuerDev
Copy link
Contributor

This is the documentation part of serverpod/serverpod#2888

To the existing example a h3 and a short intro is added for "Extending a Class", and a h3, intro and example was added explaining the sealed classes.

Please let me know where there is room for improvement 🚀

Copy link
Contributor

@SandPod SandPod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short and sweet but a couple of comments to fix.

docs/06-concepts/19-experimental.md Outdated Show resolved Hide resolved
docs/06-concepts/19-experimental.md Outdated Show resolved Hide resolved
docs/06-concepts/19-experimental.md Show resolved Hide resolved
- warning about new subtype introducing breaking changes was added
- sealed description explains about exhaustive type checking
- text in info box was updated
Copy link
Contributor

@SandPod SandPod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SandPod SandPod merged commit bd2e4ba into serverpod:main Oct 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants