Improved workflow creation vs update process in the Dashboard #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- An `IsNew` variable was added to the state, which tracks whether the workflow is new or existing. This change prevents unnecessary API calls, reducing 404 errors and improving efficiency. Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
JBBianchi
added
type: enhancement
- An `IsNew` variable was added to the state, which tracks whether the function is new or existing. This change prevents unnecessary API calls, reducing 404 errors and improving efficiency. Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
This PR introduces an improvement in the workflow creation/update page of the Synapse Dashboard by optimizing the API call behavior.
Previously, the application relied on calling the API to check if a workflow definition already existed, leading to a significant number of 404 errors in the logs when the definition was not found. This behavior was suboptimal and caused unnecessary strain on the API.
To address this, a variable in the page's state has been introduced to determine if the workflow needs to be created or updated. In addition, when creating, if a conflict is detected, the process will fallback and try to "update" (= create a new version).
Closes #457