Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the API client to use SSEs for watching and monitoring resources #440

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

cdavernas
Copy link
Member

Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it:

  • Fixes the API client to use SSEs for watching and monitoring resources
  • Fixes the actions to monitor and watch resources using SSEs in both cluster and namespaced resource controllers to flush headers directly

Additional information:

This fix is needed because the other, non SSE-based actions, block until the first event is consumed

…itoring resources

fix(Api): Fixed the actions to monitor and watch resources using SSEs in both cluster and namespaced resource controllers to flush headers directly

Signed-off-by: Charles d'Avernas <[email protected]>
@cdavernas cdavernas added priority: high Indicates a high priority issue app: api Concerns the API weight: 2 An issue with a low development impact type: fix labels Oct 24, 2024
@cdavernas cdavernas added this to the v1.0.0 milestone Oct 24, 2024
@cdavernas cdavernas self-assigned this Oct 24, 2024
@cdavernas cdavernas merged commit 71d9adb into main Oct 24, 2024
3 checks passed
@cdavernas cdavernas deleted the fix-watch-and-monitor-client branch October 24, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: api Concerns the API priority: high Indicates a high priority issue type: fix weight: 2 An issue with a low development impact
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant