[Fix_#449] Checking pattern #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjtirado
force-pushed
the
Fix_#449
branch
2 times, most recently
from
c1c321e
to
118d6ac
Compare
fjtirado
commented
Nov 4, 2024
| private static final String PATTERN = "pattern"; | ||
|
|
||
| private enum Format { | ||
| URI_TEMPLATE("^[A-Za-z][A-Za-z0-9+\\-.]*://.*"); |
There was a problem hiding this comment.
The idea is to add adittional formats when needed.
Right now, the only format that is used by the spec and not handle is json-pointer, but I could not find a good one for this ABNF yet
json-pointer = *( "/" reference-token )
reference-token = *( unescaped / escaped )
unescaped = %x00-2E / %x30-7D / %x7F-10FFFF
; %x2F ('/') and %x7E ('~') are excluded from 'unescaped'
escaped = "~" ( "0" / "1" )
; representing '~' and '/', respectively
fjtirado
commented
Nov 4, 2024
|
|
||
| private static TaskExecutorFactory instance = new DefaultTaskExecutorFactory(); | ||
|
|
||
| public static TaskExecutorFactory get() { |
There was a problem hiding this comment.
This has been made public, allowing other implementations to reuse the code executing task as desired.
Signed-off-by: Francisco Javier Tirado Sarti <[email protected]>
ricardozanini
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #449