-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Release Workflow #249
Introduce Release Workflow #249
Conversation
Sonatype Lift is retiringSonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. |
@tsurdilo we just need the keys configured as secrets in this repo, please see the PR description 🙏 |
9b39334
to
a4c454a
Compare
@ricardozanini Thanks for tagging me. I am not aware of how the current release process works. Currently fixes for older sdk versions are built out from the branches 4.0, 3.0 etc. These release workflow changes I assume would be propagated to the branches from which older sdks are supported? |
@manick02 I'll cherry-pick to 4.0.x branch if it makes sense there. This workflow tags the main branch upon release with the name version. About branching, I'll continue doing it manually from the tag after the release. |
Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
2060e09
to
6e894cd
Compare
@manick02 do you mind taking a second look and approve this PR? We need to release, too many CVEs in the current version. |
@@ -124,7 +124,7 @@ | |||
</executions> | |||
</plugin> | |||
<plugin> | |||
<groupId>com.coveo</groupId> | |||
<groupId>com.spotify.fmt</groupId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: should we have made this change in different PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old one had conflicts during the build and it was outdated :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
With this PR we can automate the release.
Special notes for reviewers:
Work to be done:
.github/release/maven-settings.xml.gpg
file signed with the GPG keyAdditional information (if needed):
I've removed the current actions since they were pushing SNAPSHOTs to Maven Central and not doing an actual release.
To do a release, one must open a PR and change the info in
./github/project.yml
. The action will branch the repo, and push the tags and the released artifact to Maven Central.