Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: convert port to number type #185

Open
wants to merge 1 commit into
base: beta
Choose a base branch
from

Conversation

hiramatsutaku
Copy link

@hiramatsutaku hiramatsutaku commented Apr 24, 2023

When using multiple APIs, port is incremented.(See: #92)
However, when I specified port from the environment variable, it became a string and could not be incremented, resulting in the following error.

❯ APPSYNC_PORT=20004 npx sls offline start
AppSync Simulator: Error: Port 2000410 is already in use. Please kill the program using this port and restart Mock
...

So, I fixed this even if port/wsPort is specified from an environment variable.

- If port is specified from the environment variable, it may be string type
@plezan plezan changed the base branch from master to beta January 24, 2024 08:35
@plezan plezan self-assigned this Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants