[Chore] Update some dependencies, cleanup #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: supporting ghc-8.8 forces us to have some conditionals in the .cabal file. Not a big deal, but still some overhead. Nowadays this compiler version is rather old, and since we claim to always support 3 versions (as a minimum) it's safe to drop the oldest supported one. Solution: remove it from CI config and tested-with, remove related conditionals.
Problem: Stackage LTS badge in the README was commented out due when the package got eliminated. However, now it's available, so there is no reason to have the badge commented out. Solution: uncomment it.
Problem: TypeInType extension got deprecated recently, we are still using it in Debug.hs. Solution: enable DataKinds instead.
Problem: there is a newer LTS version than specified in stack.yaml, and a newer Stack version than specified in the CI config. It's not a problem per-se, but it's a good practice to update all versions from time to time. Solution: 1. Update the resolver in stack.yaml to the latest LTS one at the moment of doing this change (lts-22.4). 2. Update Stack version in ci.yml to the latest released one (2.13.1). 3. Update the GHC version there to match the one implied by the resolver.
gromakovsky
force-pushed
the
gromak/maintenance-jan24
branch
from
370d84a to
d18a2d0
Compare
Problem: we don't claim to support ghc-9.6.3, it's time to do so. Solution: 1. Add 9.6.3 to tested-with. 2. Test it with cabal on CI on all platforms. As a consequence, 9.4 will be tested only on Linux from now on. Also update the Cabal version in CI config while we are at it.
gromakovsky
force-pushed
the
gromak/maintenance-jan24
branch
from
d18a2d0 to
8a3cdfb
Compare
gromakovsky
force-pushed
the
gromak/maintenance-jan24
branch
from
0d5cbfe to
e468bf2
Compare
gromakovsky
force-pushed
the
gromak/maintenance-jan24
branch
from
e468bf2 to
442fe96
Compare
gromakovsky
force-pushed
the
gromak/maintenance-jan24
branch
3 times, most recently
from
ca5f86d to
5aad5ad
Compare
Martoon-00
reviewed
Mar 13, 2024
Problem: there is ghc-9.8 for a while, but we don't support it for several reasons. Solution: 1. Permit text up to 2.1.1 (currently the latest one). The rewrite rules still work and benchmarks produce expected results. 2. Add explicit kind signatures for custom operators, because otherwise there is a warning. 3. Add 9.8.1 to tested-with. 4. Update the CI config accordingly. Let's still consider 9.6 as the main version (it's probably more popular) and use it for 3 OS.
In benchmarks we don't care that much about runtime safety.
gromakovsky
force-pushed
the
gromak/maintenance-jan24
branch
from
5aad5ad to
76966f3
Compare
Martoon-00
approved these changes
Mar 15, 2024
test/Test/Universum/StringProps.hs
Outdated
| @@ -1,3 +1,8 @@ | |||
| -- Some tests in this module have a caveat: they depend on compiler | |||
| -- optimizations and will likely fail if compiled with -O0. | |||
| -- That's because they depend on rewrite rules (and tests these rules), | |||
There was a problem hiding this comment.
Suggested change
| -- That's because they depend on rewrite rules (and tests these rules), | |
| -- That's because they depend on rewrite rules (and test these rules), |
(I guess)
There was a problem hiding this comment.
Right, done, going to merge and make a release once CI passes.
See the comment, should be clear.
gromakovsky
force-pushed
the
gromak/maintenance-jan24
branch
from
76966f3 to
6b8b1c4
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Routine changes to support newer GHC versions.
Related issues(s)
None
✓ Checklist for your Pull Request
Ideally a PR has all of the checkmarks set.
If something in this list is irrelevant to your PR, you should still set this
checkmark indicating that you are sure it is dealt with (be that by irrelevance).
are inextricably linked. Otherwise I should open multiple PR's.
I checked whether these changes impact the
.hlint.yamlrulesand updated them if needed.
Related changes (conditional)
Tests
silently reappearing again.
Documentation
I checked whether I should update the docs and did so if necessary:
Record your changes
Unreleasedsection if necessary) if my changes are visible to the usersand
Stylistic guide (mandatory)
My commit history is clean (only contains changes relating to my
issue/pull request and no reverted-my-earlier-commit changes) and commit
messages start with identifiers of related issues in square brackets.
Example:
[#42] Short commit descriptionIf necessary both of these can be achieved even after the commits have been
made/pushed using rebase and squash.
✓ Release Checklist
universum.cabal.under the "Unreleased" section to a new section for this release version.
I added
@sincehaddock annotations.with a summary of all user-facing changes.
vX.Y.Z