make sure to check post vars too when a post request is done to the API #223
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made this to address #220
instead of doing the
if (request->hasParam()) {request->getParam()}
routine everywhere, I decided to make a method that checks both the post and get parameters, returns them if set or throws otherwise.Still a draft because I haven't finished testing and still want to refactor a bit (e.g. throwing more specific exception).
I'm not very fluent in C++ (my native language is PHP) so LMK if there's anything I can learn to improve.