forked from SmartEVSE/SmartEVSE-3
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POST body not parsed on POST requests #220
Comments
I was not aware of this "awkwardness", as were the original authors of the API, Im sure. Since backward incompatibility would hit al lot of users, including the ones using the homeassistant integration, I wouldnt accept such a PR. Is there no way compatibility could be warranteed, e.g. autodetecting which of both methods is used? |
That'll be a couple lines extra code, I'll see if I can get to it |
This was referenced Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Usually, a POST requests has a POST body containing the data, either
x-www-form-urlencoded
orjson
. But in the SmartEVSE API you need to do a POST request but provide data using GET parameters (in the URL). This is kind of awkward.The issue is
request->getParam()
is called in POST requests, without setting the 2nd parameter (post) to true.I'd like to fix this.
Would a PR be accepted if the behavior is not backward-compatible?
The text was updated successfully, but these errors were encountered: