Skip to content

Commit

Permalink
CRAN Submission
Browse files Browse the repository at this point in the history
This commit is the submitted version to CRAN. See #11 for a full list of tasks.

Please refer to the NEWS.md for a full list of changes.
  • Loading branch information
serkor1 committed May 31, 2024
1 parent f9f9bca commit 970bfb8
Show file tree
Hide file tree
Showing 11 changed files with 81 additions and 85 deletions.
1 change: 1 addition & 0 deletions .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,4 @@ playground
^CODE_OF_CONDUCT\.md$
^data-raw$
^codemeta\.json$
NEWS.Rmd
3 changes: 3 additions & 0 deletions CRAN-SUBMISSION
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Version: 1.3.1
Date: 2024-05-31 19:29:49 UTC
SHA: f9f9bcaabc82e342e0f6cee986cb838f44dc4929
3 changes: 2 additions & 1 deletion NEWS.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
output: github_document
always_allow_html: true
---
<!-- NEWS.md is generated from NEWS.Rmd. Please edit that file -->

```{r setup, include = FALSE}
# set options
Expand All @@ -14,7 +15,7 @@ knitr::opts_chunk$set(
message = FALSE,
warning = FALSE,
dpi = 120,
fig.align = "center"
fig.align = 'center'
)
```

Expand Down
6 changes: 4 additions & 2 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@

<!-- NEWS.md is generated from NEWS.Rmd. Please edit that file -->

# cryptoQuotes 1.3.1

## General
Expand Down Expand Up @@ -70,12 +72,12 @@ tail(
```

#> open_interest
#> 2024-05-31 14:00:00 3018.442
#> 2024-05-31 15:00:00 3013.342
#> 2024-05-31 16:00:00 2957.343
#> 2024-05-31 17:00:00 2960.819
#> 2024-05-31 18:00:00 2954.668
#> 2024-05-31 19:00:00 2981.381
#> 2024-05-31 19:00:00 2983.686
#> 2024-05-31 20:00:00 2996.449

</details>

Expand Down
2 changes: 1 addition & 1 deletion README.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ knitr::opts_chunk$set(
[![CRAN status](https://www.r-pkg.org/badges/version/cryptoQuotes)](https://CRAN.R-project.org/package=cryptoQuotes)
[![CRAN RStudio mirror downloads](https://cranlogs.r-pkg.org/badges/last-month/cryptoQuotes?color=blue)](https://r-pkg.org/pkg/cryptoQuotes)
[![R-CMD-check](https://github.com/serkor1/cryptoQuotes/actions/workflows/R-CMD-check.yaml/badge.svg)](https://github.com/serkor1/cryptoQuotes/actions/workflows/R-CMD-check.yaml)
[![codecov](https://codecov.io/gh/serkor1/cryptoQuotes/graph/badge.svg?token=D7NF1BPVL5)](https://codecov.io/gh/serkor1/cryptoQuotes)
[![codecov](https://codecov.io/gh/serkor1/cryptoQuotes/graph/badge.svg?token=D7NF1BPVL5)](https://app.codecov.io/gh/serkor1/cryptoQuotes)
[![Lifecycle: stable](https://img.shields.io/badge/lifecycle-stable-brightgreen.svg)](https://lifecycle.r-lib.org/articles/stages.html#stable)
![GitHub last commit (branch)](https://img.shields.io/github/last-commit/serkor1/cryptoQuotes/development)
<!-- badges: end -->
Expand Down
122 changes: 61 additions & 61 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ status](https://www.r-pkg.org/badges/version/cryptoQuotes)](https://CRAN.R-proje
[![CRAN RStudio mirror
downloads](https://cranlogs.r-pkg.org/badges/last-month/cryptoQuotes?color=blue)](https://r-pkg.org/pkg/cryptoQuotes)
[![R-CMD-check](https://github.com/serkor1/cryptoQuotes/actions/workflows/R-CMD-check.yaml/badge.svg)](https://github.com/serkor1/cryptoQuotes/actions/workflows/R-CMD-check.yaml)
[![codecov](https://codecov.io/gh/serkor1/cryptoQuotes/graph/badge.svg?token=D7NF1BPVL5)](https://codecov.io/gh/serkor1/cryptoQuotes)
[![codecov](https://codecov.io/gh/serkor1/cryptoQuotes/graph/badge.svg?token=D7NF1BPVL5)](https://app.codecov.io/gh/serkor1/cryptoQuotes)
[![Lifecycle:
stable](https://img.shields.io/badge/lifecycle-stable-brightgreen.svg)](https://lifecycle.r-lib.org/articles/stages.html#stable)
![GitHub last commit
Expand Down Expand Up @@ -279,122 +279,122 @@ volume
<tbody>
<tr>
<td style="text-align:left;">
2024-05-30 16:00:00
2024-05-31 18:00:00
</td>
<td style="text-align:center;">
68623.99
67215.58
</td>
<td style="text-align:center;">
68826.31
67352.41
</td>
<td style="text-align:center;">
68472.35
66670
</td>
<td style="text-align:center;">
68671.02
67000.01
</td>
<td style="text-align:left;">
1274.59558
2093.77494
</td>
</tr>
<tr>
<td style="text-align:left;">
2024-05-30 16:30:00
2024-05-31 18:30:00
</td>
<td style="text-align:center;">
68671.02
67000.01
</td>
<td style="text-align:center;">
68756.41
67221.53
</td>
<td style="text-align:center;">
68256.29
66876.8
</td>
<td style="text-align:center;">
68359.6
67200.01
</td>
<td style="text-align:left;">
758.51827
788.25693
</td>
</tr>
<tr>
<td style="text-align:left;">
2024-05-30 17:00:00
2024-05-31 19:00:00
</td>
<td style="text-align:center;">
68359.6
67200.01
</td>
<td style="text-align:center;">
68460.84
67459.66
</td>
<td style="text-align:center;">
68144
67160.3
</td>
<td style="text-align:center;">
68424
67417.98
</td>
<td style="text-align:left;">
638.09219
598.68095
</td>
</tr>
<tr>
<td style="text-align:left;">
2024-05-30 17:30:00
2024-05-31 19:30:00
</td>
<td style="text-align:center;">
68424.01
67417.98
</td>
<td style="text-align:center;">
68612
67455.93
</td>
<td style="text-align:center;">
68367.65
67287.97
</td>
<td style="text-align:center;">
68530.76
67342.77
</td>
<td style="text-align:left;">
911.26349
287.26257
</td>
</tr>
<tr>
<td style="text-align:left;">
2024-05-30 18:00:00
2024-05-31 20:00:00
</td>
<td style="text-align:center;">
68530.77
67342.77
</td>
<td style="text-align:center;">
68600
67444.47
</td>
<td style="text-align:center;">
68384
67288.2
</td>
<td style="text-align:center;">
68427.18
67305.5
</td>
<td style="text-align:left;">
411.48792
383.04002
</td>
</tr>
<tr>
<td style="text-align:left;">
2024-05-30 18:30:00
2024-05-31 20:30:00
</td>
<td style="text-align:center;">
68427.19
67305.5
</td>
<td style="text-align:center;">
68460
67427.68
</td>
<td style="text-align:center;">
68417.81
67170
</td>
<td style="text-align:center;">
68459.99
67400
</td>
<td style="text-align:left;">
71.38386
468.98276
</td>
</tr>
</tbody>
Expand Down Expand Up @@ -562,86 +562,86 @@ ls_ratio
<tbody>
<tr>
<td style="text-align:left;">
2024-05-30 16:00:00
2024-05-31 18:00:00
</td>
<td style="text-align:center;">
0.636
0.679
</td>
<td style="text-align:center;">
0.364
0.321
</td>
<td style="text-align:center;">
1.746
2.114
</td>
</tr>
<tr>
<td style="text-align:left;">
2024-05-30 16:30:00
2024-05-31 18:30:00
</td>
<td style="text-align:center;">
0.624
0.687
</td>
<td style="text-align:center;">
0.376
0.313
</td>
<td style="text-align:center;">
1.662
2.199
</td>
</tr>
<tr>
<td style="text-align:left;">
2024-05-30 17:00:00
2024-05-31 19:00:00
</td>
<td style="text-align:center;">
0.623
0.696
</td>
<td style="text-align:center;">
0.378
0.304
</td>
<td style="text-align:center;">
1.649
2.289
</td>
</tr>
<tr>
<td style="text-align:left;">
2024-05-30 17:30:00
2024-05-31 19:30:00
</td>
<td style="text-align:center;">
0.624
0.699
</td>
<td style="text-align:center;">
0.376
0.301
</td>
<td style="text-align:center;">
1.662
2.323
</td>
</tr>
<tr>
<td style="text-align:left;">
2024-05-30 18:00:00
2024-05-31 20:00:00
</td>
<td style="text-align:center;">
0.623
0.696
</td>
<td style="text-align:center;">
0.377
0.304
</td>
<td style="text-align:center;">
1.65
2.288
</td>
</tr>
<tr>
<td style="text-align:left;">
2024-05-30 18:30:00
2024-05-31 20:30:00
</td>
<td style="text-align:center;">
0.62
0.696
</td>
<td style="text-align:center;">
0.38
0.304
</td>
<td style="text-align:center;">
1.632
2.293
</td>
</tr>
</tbody>
Expand Down
26 changes: 7 additions & 19 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,22 +2,10 @@

0 errors ✔ | 0 warnings ✔ | 1 note ✖

### The note

```
The Title field should be in title case. Current version is:
'A Streamlined Access to Cryptocurrency OHLC-V Market Data and Sentiment Indicators'
In title case that is:
'A Streamlined Access to Cryptocurrency OHLC-v Market Data and Sentiment Indicators'
```

This `note` is related to `OHLC-V`, and since `OHLC-V` is an accepted shorthand for Open, High, Low, Close and Volume I believe this `note` should
be ignored.

## Resubmission

This is a resubmission. In this version I have updated many elements in the library, but
most importantly the unittests are being conducted in a manner that is robust to timing
errors.


❯ checking installed package size ... NOTE
installed size is 13.1Mb
sub-directories of 1Mb or more:
doc 11.9Mb

This is beyond my technical knowledge, but here is a related SO-post:
https://stackoverflow.com/questions/38639266/r-cmd-check-unusual-checking-installed-package-size-note
3 changes: 2 additions & 1 deletion man/donchian_channel.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file modified man/figures/README-chartquote(deficiency)-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified man/figures/README-chartquote-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified man/figures/README-unnamed-chunk-3-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 970bfb8

Please sign in to comment.