fix(packages_simple-pie): doughnut inner option ignored

serjilyashenko · Jun 21, 2024 · b360a88 · b360a88
1 parent 9b1ce36
commit b360a88
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/.changeset/loud-masks-glow.md b/.changeset/loud-masks-glow.md
@@ -0,0 +1,5 @@
+---
+"simple-pie": patch
+---
+
+Bug fix: Doughnut inner option ignored (https://github.com/serjilyashenko/simple-pie-project/issues/11)
diff --git a/packages/pie-math/src/index.ts b/packages/pie-math/src/index.ts
@@ -13,7 +13,7 @@ export function buildPieSectors(values: Array<number>): Array<string> {
 
 export function buildDoughnutSectors(
   values: Array<number>,
-  inner: number = 0.5,
+  inner: number,
 ): Array<string> {
   const angleCoordinates: Array<TSectorCoordinate> = castValuesToAngles(values);
 

diff --git a/packages/simple-pie/src/simple-pie.ts b/packages/simple-pie/src/simple-pie.ts
@@ -88,10 +88,13 @@ export function simpleDoughnutElement(
   options: TDoughnutOptions = {},
 ): SVGElement {
   const resultOptions = { ...defaultDoughnutOptions, ...options };
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   const { inner, ...pieOptions } = resultOptions;
 
-  return _buildSvgElement(buildDoughnutSectors, values, pieOptions);
+  return _buildSvgElement(
+    (_values) => buildDoughnutSectors(_values, inner),
+    values,
+    pieOptions,
+  );
 }
 
 export const simplePie = simplePieElement;