Update Readme.md #2
Conversation
Updating code sample to reflect how to Configure. (based on example code)
There was a problem hiding this comment.
My congratulations! This is the first pull request to this repo! 🎉
You're right, the docs contain mistake, I didn't yet push the most recent version. Thank you very much for you pull request.
Overall it looks great, I just want one styling fix to be made before merging into master
| //... | ||
| app.UseWebpackDevServer(); | ||
| } | ||
| else |
There was a problem hiding this comment.
There is an extra indentation before else, please remove it
|
@jafin I've update the master and published the latest changes to nuget: Now README is valid, except this line: public void Configure(IApplicationBuilder app)It doesn't include the hosting environment variable and your PR fixes it. Could you please rebase with the latest master and update your PR? The latest master also includes the correct version of xunit, so CI builds would pass. |
Updating code sample to reflect how to Configure. (based on example code)