Big endian fixes #308
Open
Big endian fixes #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes compilation error: unknown type name 'cpu_set_t' Signed-off-by: Eneas U de Queiroz <[email protected]>
move ngx_config.h and ngx_core.h to top of ngx_rtp_cenc.c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, is there a way to push bigendian fixes for nginx-rtmp to sergey-dryabzhinsky/nginx-rtmp-module? Original Arut's code is little-endian based, compilation on big-endian platforms is possible, but at runtime it sees some data incorrectly swapped and fails.
I selected repo "ut0mt8/nginx-rtmp-module" as a base for the changes, as that repo is currently used to compile OpenWrt packages. Unfortunately ut0mt8 seems unresponsive at the moment. Kudos to him for his DASH improvements. I would like to donate the fix to the community, but I have no intention to become "yet another fork of nginx-rtmp".
Current options:
Can I help with anything? Although there are conflicts in this PR, don't worry. Just two places in code (marginal issues) and a large section in README.md.
Jan