Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not round up volume sizes #266

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: do not round up volume sizes #266

wants to merge 1 commit into from

Conversation

johanfleury
Copy link

Pull Request

What?

Do not round up volume sizes, let the user decides what resource they want to allocate.

Why? (reasoning)

Fixes #223

Acceptance

Please use the following checklist:

  • you linked an issue (if applicable)
  • you included tests (if applicable)
  • you ran conformance (make conformance)
  • you linted your code (make lint)
  • you linted your code (make unit)

@johanfleury johanfleury mentioned this pull request Oct 4, 2024
Open
@johanfleury johanfleury force-pushed the fix/do-not-round-up-volume-size branch 4 times, most recently from a48aab7 to de95f24 Compare October 4, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Storage size requests lower than 1GiB are not respected
1 participant
@johanfleury