Fix deserializing snowflakes from non-self-describing formats #2958
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously snowflakes were deserialized using
deserialize_any
which is recommended against because it prevents usage with non-self-describing formats such as Bincode (which was my use-case which caused me to run up against this issue).I simply replaced
deserialize_any
withdeserialize_str
. Although this causes the deserializer to expect to read astr
, the bytes representation of1234
and"1234"
are the same so it works perfectly. All tests pass.