Fix and make edit_role_position plural
#2954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
model
GnomedDev
requested changes
Aug 23, 2024
GnomedDev
approved these changes
Aug 23, 2024
GnomedDev
changed the title
edit_role_position pluraledit_role_position plural
GnomedDev
added
breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a regression introduced to the
edit_role_positionendpoint in #2806 - this endpoint expects an array of json objects but a single object was being sent to the API, not inside of an array. This means the response would always error due to invalid format.This PR fixes said bug by pluralizing the endpoint to take a list of roles to edit. The list will be serialized as a JSON array.