Fix deserialisation failure of audit logs when the user ID is absent #2931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kind of fixes serenity-rs#2929. Real fix would be to account for this at the type level with `Option<T>`, but this change cannot be committed to `current` as it is a breaking change.
|
Actually not as simple of a fix as I initially thought. The I'll just close this. While I could add custom deserialisation behaviour to allow the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind of fixes #2929.
Real fix would be to account for this at the type level with
Option<T>, but this change cannot be committed tocurrentas it is a breaking change.