Fix CI #2610
Merged
Fix CI #2610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
builder
mkrasnitski
force-pushed
the
fix-simd-json
branch
from
b73b6c1
to
a337704
Compare
github-actions
bot
removed
model
|
I'm just gonna make this PR for passing all of CI, not just simd-json. |
mkrasnitski
force-pushed
the
fix-simd-json
branch
from
a337704
to
a4df4c8
Compare
mkrasnitski
force-pushed
the
fix-simd-json
branch
from
52812db
to
904e52c
Compare
github-actions
bot
added
cache
mkrasnitski
force-pushed
the
fix-simd-json
branch
from
904e52c
to
d13abff
Compare
github-actions
bot
added
collector
|
I don't feel like fixing MSRV at the moment, it's too much work. However, I tested it and without pinning, the MSRV is 1.67. |
arqunis
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This revives #2536 in order to fix the
simd-jsonfeature on thev0.11series and get CI to actually work again.Initially I attempted to keep the old simd-json version exported while using a newer version internally, but unfortunately this doesn't work as types from the internal version would leak into the public API (specifically in methods on
Httpwhich expect aValueorJsonMap). Therefore, because the old version ofsimd-jsonhas a soundness bug infrom_str, and because not that many people actually use this feature, I propose we just bite the bullet and upgrade tosimd-json v0.10on this branch. This way, we can provide a safe wrapper aroundsimd_json::from_str, and whilefrom_stris still exported in the prelude, it is marked unsafe.