Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clippy #2538

Merged
merged 1 commit into from
Sep 16, 2023
Merged

Fix clippy #2538

merged 1 commit into from
Sep 16, 2023

Conversation

GnomedDev
Copy link
Member

No description provided.

@github-actions github-actions bot added framework Related to the `framework` and `framework::standard` modules and/or the `command_attr` crate cache Related to the `cache`-feature. http Related to the `http` module. labels Sep 16, 2023
@mkrasnitski
Copy link
Collaborator

What lints do these trigger?

@GnomedDev
Copy link
Member Author

clippy::needless_pass_by_ref_mut
clippy::ignored_unit_patterns
clippy::unwrap_or_default

@mkrasnitski
Copy link
Collaborator

Ah, I see, these are triggered on rust beta 1.73.0

@arqunis arqunis added the enhancement An improvement to Serenity. label Sep 16, 2023
@arqunis arqunis merged commit 0a77c8c into serenity-rs:next Sep 16, 2023
20 of 21 checks passed
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Sep 21, 2023
@GnomedDev @mkrasnitski
Apply suggestions from clippy (serenity-rs#2538)
0d80c15
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 17, 2023
@GnomedDev @mkrasnitski
Apply suggestions from clippy (serenity-rs#2538)
d15b239
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 24, 2023
@GnomedDev @mkrasnitski
Apply suggestions from clippy (serenity-rs#2538)
1622542
arqunis pushed a commit to arqunis/serenity that referenced this pull request Oct 24, 2023
@GnomedDev @arqunis
Apply suggestions from clippy (serenity-rs#2538)
0872d31
arqunis pushed a commit to arqunis/serenity that referenced this pull request Oct 24, 2023
@GnomedDev @arqunis
Apply suggestions from clippy (serenity-rs#2538)
1430d88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arqunis arqunis arqunis approved these changes

@mkrasnitski mkrasnitski mkrasnitski approved these changes

Assignees
No one assigned
Labels
cache Related to the `cache`-feature. enhancement An improvement to Serenity. framework Related to the `framework` and `framework::standard` modules and/or the `command_attr` crate http Related to the `http` module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GnomedDev @mkrasnitski @arqunis