Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement guild ban pagination #2535

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Implement guild ban pagination #2535

merged 2 commits into from
Sep 18, 2023

Conversation

arqunis
Copy link
Member

@arqunis arqunis commented Sep 10, 2023

This implements user pagination for the Get Guild Bans endpoint.

@arqunis arqunis added enhancement An improvement to Serenity. discord feature Related to Discord's functionality. model Related to the `model` module. http Related to the `http` module. breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users labels Sep 10, 2023
mkrasnitski
mkrasnitski approved these changes Sep 10, 2023
View reviewed changes
Copy link
Collaborator

@mkrasnitski mkrasnitski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than some minor formatting changes.

src/http/client.rs Outdated Show resolved Hide resolved
src/http/mod.rs Outdated Show resolved Hide resolved
src/model/guild/guild_id.rs Outdated Show resolved Hide resolved
src/model/guild/mod.rs Outdated Show resolved Hide resolved
src/model/guild/partial_guild.rs Outdated Show resolved Hide resolved
@arqunis arqunis merged commit 950e524 into serenity-rs:next Sep 18, 2023
20 of 21 checks passed
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Sep 21, 2023
@arqunis @mkrasnitski
Implement guild ban pagination (serenity-rs#2535)
6dd7602 
This implements user pagination for the [Get Guild Bans](https://discord.com/developers/docs/resources/guild#get-guild-bans) endpoint.
mkrasnitski added a commit to mkrasnitski/serenity that referenced this pull request Sep 21, 2023
@mkrasnitski
Add serenity-rs#2535
c51a032
mkrasnitski added a commit to mkrasnitski/serenity that referenced this pull request Sep 21, 2023
@mkrasnitski
Add serenity-rs#2535
15c7fac
mkrasnitski added a commit to mkrasnitski/serenity that referenced this pull request Sep 21, 2023
@mkrasnitski
Add serenity-rs#2535
a7affb1
mkrasnitski added a commit to mkrasnitski/serenity that referenced this pull request Sep 21, 2023
@mkrasnitski
Add serenity-rs#2535
5a0d034
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 17, 2023
@arqunis @mkrasnitski
Implement guild ban pagination (serenity-rs#2535)
9056ee0 
This implements user pagination for the [Get Guild Bans](https://discord.com/developers/docs/resources/guild#get-guild-bans) endpoint.
mkrasnitski added a commit to mkrasnitski/serenity that referenced this pull request Oct 23, 2023
@mkrasnitski
Add serenity-rs#2535
cc16bc7
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 24, 2023
@arqunis @mkrasnitski
Implement guild ban pagination (serenity-rs#2535)
4c541e2 
This implements user pagination for the [Get Guild Bans](https://discord.com/developers/docs/resources/guild#get-guild-bans) endpoint.
arqunis added a commit to arqunis/serenity that referenced this pull request Oct 24, 2023
@arqunis
Implement guild ban pagination (serenity-rs#2535)
1c4840a 
This implements user pagination for the [Get Guild Bans](https://discord.com/developers/docs/resources/guild#get-guild-bans) endpoint.
arqunis added a commit to arqunis/serenity that referenced this pull request Oct 24, 2023
@arqunis
Implement guild ban pagination (serenity-rs#2535)
45082eb 
This implements user pagination for the [Get Guild Bans](https://discord.com/developers/docs/resources/guild#get-guild-bans) endpoint.
mkrasnitski added a commit to mkrasnitski/serenity that referenced this pull request Oct 24, 2023
@mkrasnitski
Add serenity-rs#2535
00fd996
mkrasnitski added a commit to mkrasnitski/serenity that referenced this pull request Nov 1, 2023
@mkrasnitski
Add serenity-rs#2535
77aa75f
mkrasnitski added a commit to mkrasnitski/serenity that referenced this pull request Nov 19, 2023
@mkrasnitski
Add serenity-rs#2535
4efa17f
@arqunis arqunis deleted the ban_pagination branch July 30, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkrasnitski mkrasnitski mkrasnitski approved these changes

Assignees
No one assigned
Labels
breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users discord feature Related to Discord's functionality. enhancement An improvement to Serenity. http Related to the `http` module. model Related to the `model` module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arqunis @mkrasnitski