Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow attachment updates on initial responses #273

Open
wants to merge 1 commit into
base: current
Choose a base branch
from
Open

allow attachment updates on initial responses #273

wants to merge 1 commit into from

Conversation

DocJade
Copy link

@DocJade DocJade commented May 22, 2024 •
edited
Loading

closes #272

NotNorom
NotNorom approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@NotNorom NotNorom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me. CI was also successful. I think this can be merged, right?

@jamesbt365
Copy link
Member

Rebasing will fix CI on this PR but otherwise should be good for merge without.

@matteopolak
Copy link
Contributor

matteopolak commented Jul 9, 2024 •
edited
Loading

Any update on this? Would be great if this could be added to serenity-next as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotNorom NotNorom NotNorom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding attachments to initial interaction response
4 participants
@DocJade @jamesbt365 @matteopolak @NotNorom