This repository has been archived by the owner on May 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: syntex_bitflags/src/lib.rs syntex_syntax/src/lib.rs
Conflicts: syntex_syntax/src/ext/expand.rs
# Conflicts: # syntex_bitflags/src/lib.rs
# Conflicts: # syntex_bitflags/src/lib.rs # syntex_syntax/src/ext/deriving/generic/mod.rs # syntex_syntax/src/ext/expand.rs # syntex_syntax/src/lib.rs
# Conflicts: # syntex_syntax/src/ext/expand.rs
# Conflicts: # syntex_bitflags/Cargo.lock # syntex_bitflags/Cargo.toml # syntex_bitflags/src/lib.rs
This will be slower and use more memory, but this shouldn't be a large impact until syntex is used on large codebases. Hopefully by then there will be a stable BitSet that we can use.
Conflicts: syntex_syntax/src/ext/base.rs syntex_syntax/src/ext/deriving/mod.rs syntex_syntax/src/util/small_vector.rs
Sync with master
# Conflicts: # syntex_syntax/src/ext/base.rs # syntex_syntax/src/ext/deriving/mod.rs # syntex_syntax/src/util/small_vector.rs
# Conflicts: # syntex_syntax/src/lib.rs # syntex_syntax/src/parse/parser.rs
fix(rustup): Update syntex
fix(syntex_syntax): Don't expand builtin derive decorators
# Conflicts: # syntex_syntax/src/diagnostic.rs # syntex_syntax/src/lib.rs
# Conflicts: # syntex_syntax/src/diagnostic.rs
# Conflicts: # syntex_syntax/src/ext/expand.rs
# Conflicts: # syntex_syntax/src/ext/base.rs # syntex_syntax/src/ext/expand.rs # syntex_syntax/src/ext/quote.rs # syntex_syntax/src/fold.rs # syntex_syntax/src/lib.rs # syntex_syntax/src/parse/parser.rs # syntex_syntax/src/util/small_vector.rs
# Conflicts: # syntex_syntax/src/ext/asm.rs # syntex_syntax/src/ext/base.rs # syntex_syntax/src/ext/deriving/mod.rs # syntex_syntax/src/lib.rs # syntex_syntax/src/print/pprust.rs # syntex_syntax/src/ptr.rs
In the core rust repo, this was migrated into a separate crate. I don't think it's necessary to replicate that crate since all we want is #[derive] support.
# Conflicts: # syntex_syntax/src/ext/expand.rs # syntex_syntax/src/parse/parser.rs
r? @erickt |
I am waiting for this to land. Are there any holdups? |
@hansihe: It seems @erickt is away.
Then use a local path to depend on the updated version.
I think cargo-vendor could make this process somehow easier. |
Yeah, sorry traveling for the holidays, looking now! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.